-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing arguments containing spaces into pygmt functions #1487
Merged
Merged
Changes from 6 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b5ad405
Replace spaces in arguments with octal code 040
weiji14 14648c2
Remove workarounds for spaces in fig.subplot's autolabel and title args
weiji14 924f439
Remove workaround for spaces in fig.text's -F argument
weiji14 707745f
Remove double quotes around legend label test examples
weiji14 03e4308
Edit test_rose_no_sectors to remove single quotes from title
weiji14 095449a
Remove workaround for spaces in fig.psconvert prefix
weiji14 d81b80b
Format using blackdoc and fix flake8 error
weiji14 dd849cb
Merge branch 'main' into arg_with_space
weiji14 c29e632
Ensure spaces in pygmt.config arguments can work
weiji14 83c8c3b
Manually handle prefix -F in psconvert
weiji14 2ba8420
Merge branch 'main' into arg_with_space
weiji14 b58af8b
Merge branch 'main' into arg_with_space
weiji14 3ec7727
Handle PROJ4 strings with spaces
weiji14 f19c41b
Use Modifier Letter Colon instead of regular colon to fix WIndows tests
weiji14 7a518a1
Merge branch 'main' into arg_with_space
weiji14 9774d5e
Try using underscore instead of Modifier Letter Colon
weiji14 ff40d27
Refactor the whole function using a single loop
weiji14 36fdec5
Merge branch 'main' into arg_with_space
weiji14 6c399ba
Merge branch 'main' into arg_with_space
weiji14 4770396
Merge branch 'main' into arg_with_space
weiji14 801ba01
Raise GMTInvalidInput if no prefix argument is passed to psconvert
weiji14 ecb580e
Merge branch 'main' into arg_with_space
weiji14 a526d45
Fix rst syntax in pygmt/helpers/utils.py
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
outs: | ||
- md5: 8e1c47b1cf6001dad3b3c0875af4562e | ||
size: 150390 | ||
- md5: ce2d5cd1415b7c7bbeea5bf6ff39c480 | ||
size: 150288 | ||
path: test_rose_no_sectors.png |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
"+t'Windrose diagram'"
still work or not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does still work, but the single quotes would be printed. I think it was a typo from whoever wrote that test.