-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog entry for v0.4.1 #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just some comments, mostly on the highlight items.
doc/changes.md
Outdated
* [@sean0921](https://github.com/sean0921) | ||
* [Soham Banerjee](https://github.com/soham4abc) | ||
* [Jiayuan Yao](https://github.com/core-man) | ||
* [@yohaimagen](https://github.com/yohaimagen) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @sean0921 and @yohaimagen to see if they would like their full name in the list. If not we can just go by their GitHub username.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use my full name please, Yohai Magen, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to use my full name please, Yohai Magen, thanks!
Thanks. Done in 5578ece.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late. Just change my full name to Sean Li-Shin Ho for documents in main
branch, or I can make a PR for this if needed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've edited in your full name at https://github.com/GenericMappingTools/pygmt/releases/tag/v0.4.1. Feel free to open a PR to change things in https://github.com/GenericMappingTools/pygmt/blob/v0.4.1/doc/changes.md#contributors (you're also welcome to add your name to AUTHORS.md if you're keen on contributing more in the future.
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Michael Grund <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after merging #1415.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge after #1415 is done!
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good to me aside from one minor typo... Do we want to wait a bit longer, or merge this in and get on with tagging the release? If no objections I'll merge this in <1 hour at UTC 11:00?
Co-authored-by: Wei Ji <[email protected]>
Maybe we could still wait for about a few hours to see if Will is okay? |
Sounds good. Just want to make the 7 Aug 2021 deadline (specifically before it turns 8 Aug at UTC). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Let's do it now~~ |
* Add changelog entry for v0.4.1 * Add team page to highlight * Add change from master to main to highlight * Add Yohai Magen to citation Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Michael Grund <[email protected]>
Description of proposed changes
This PR is a draft changelog entry for v0.4.1.
Preview: https://pygmt-git-changelog-release-gmt.vercel.app/changes.html#changelog
Previous release at #1341
Changelog made by following the instructions at https://github.com/GenericMappingTools/pygmt/blob/main/doc/maintenance.md#updating-the-changelog
TODO:
Relates to #1402
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version