Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3 arc minute relief tile containing Iceland to cache #1398

Merged
merged 6 commits into from
Aug 3, 2021
Merged

Add 3 arc minute relief tile containing Iceland to cache #1398

merged 6 commits into from
Aug 3, 2021

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Jul 29, 2021 •
edited
Loading

Description of proposed changes

As discussed in #1396 this PR adds the 3 arc minute global relief data to cache.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund
Add 1 arc minute global relief data to cache
99822bd 
As discussed in #1396 this PR adds the 1 arc minute global relief data to cache.
@michaelgrund michaelgrund added the enhancement Improving an existing feature label Jul 29, 2021
@michaelgrund michaelgrund mentioned this pull request Jul 29, 2021
Merged
5 tasks
core-man
core-man reviewed Jul 29, 2021
View reviewed changes
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
@michaelgrund michaelgrund changed the title Add 1 arc minute global relief data to cache Add 3 arc minute global relief data to cache Jul 31, 2021
seisman
seisman reviewed Jul 31, 2021
View reviewed changes
pygmt/helpers/testing.py Outdated Show resolved Hide resolved
@seisman seisman added this to the 0.4.1 milestone Jul 31, 2021
@michaelgrund michaelgrund changed the title Add 3 arc minute global relief data to cache Add 3 arc minute relief tile containing Iceland to cache Aug 2, 2021
weiji14
weiji14 approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please manually trigger the cache workflow in .github/workflows/cache_data.yaml (as you did before in #1097) and we should be able to merge this PR in soon.

@michaelgrund
Copy link
Member Author

Looks good! Please manually trigger the cache workflow in .github/workflows/cache_data.yaml (as you did before in #1097) and we should be able to merge this PR in soon.

Done!

@seisman seisman merged commit a8d8837 into master Aug 3, 2021
@seisman seisman deleted the add-cache-1arcmin branch August 3, 2021 17:50
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog and removed enhancement Improving an existing feature labels Aug 5, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@michaelgrund
Add 3 arc minute relief tile containing Iceland to cache (GenericMapp…
fc9fbde 
…ingTools#1398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@core-man core-man core-man left review comments

@weiji14 weiji14 weiji14 approved these changes

@seisman seisman seisman approved these changes

Assignees
No one assigned
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelgrund @seisman @weiji14 @core-man