Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gallery example for different colormaps in subplots #1394

Merged
merged 5 commits into from
Jul 28, 2021

Conversation

core-man
Copy link
Member

@core-man core-man commented Jul 23, 2021

Description of proposed changes

This PR revises the example shown in https://forum.generic-mapping-tools.org/t/different-colorbars-for-subplots/1797/7 to clarify how to use different colormaps for subplots.

The regional Earth relief is chosen to be the same as the Create a region map tutorial.

Fixes #1338

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the documentation Improvements or additions to documentation label Jul 24, 2021
@willschlitzer willschlitzer added this to the 0.4.1 milestone Jul 24, 2021
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change 😉.

examples/gallery/embellishments/colorbars_multiple.py Outdated Show resolved Hide resolved
Co-authored-by: Michael Grund <[email protected]>
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jul 26, 2021
@weiji14
Copy link
Member

weiji14 commented Jul 26, 2021

Anyone have any other suggestions/comments?

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@seisman seisman merged commit 6a4b871 into master Jul 28, 2021
@seisman seisman deleted the colormaps-subplot branch July 28, 2021 17:44
@seisman seisman changed the title Add how to use different colormaps for subplots Add a gallery example for different colormaps in subplots Jul 28, 2021
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 28, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery/tutorial example showing how to use different colormaps for subplots
5 participants