-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add return statement to grdclip and grdgradient docstring #1390
Add return statement to grdclip and grdgradient docstring #1390
Conversation
💖 Thanks for opening this pull request! 💖 Please make sure you read our contributing guidelines and abide by our code of conduct. A few things to keep in mind:
|
Hey @meghanrjones , I have just added the docstring please review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request, @kadatatlukishore! Nice work! I have made two small suggestions that add one blank line. The first is for separation from the other section of the docstring and the second is required for the list to be rendered properly in sphinx. You can check out the Vercel preview if you want to see the built docs.
Hello @meghanrjones , made the required changes. Preview look fine. Thanks for the suggestions ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I'll leave this PR open for up to a day before merging, just in case any of the other maintainers have comments. Thanks again for your contribution!
/format |
Seems like pygmt/pygmt/src/grdgradient.py Line 94 in 9b60f5c
Thanks! |
@weiji14 do you want this change in the same or a separate pull request? |
I think it's ok to have it in the same pull request since it is a related change and not too big. But ok with making it into a separate thing if it's a bit troublesome. |
I can work on the same pull request. Thanks @weiji14 |
/format |
Hello @meghanrjones , Should I have to make any changes ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to manually remove these whitespaces in blank lines.
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 Please open a new pull request to add yourself to the |
Great work @kadatatlukishore and thanks again for addressing this issue! 🎉 |
Description of proposed changes
Updated the docstring in grdclip.py to have a return statement.
Fixes #1388
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version