-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow to upload baseline images as a release asset #1317
Conversation
Because the workflow only runs when a new release is made, I committed it directly to my own fork (https://github.com/seisman/pygmt/blob/master/.github/workflows/release-baseline-images.yml), and made a release at https://github.com/seisman/pygmt/releases/tag/v0.3.2. The workflow runs well (https://github.com/seisman/pygmt/actions/workflows/release-baseline-images.yml) and the baseline images are correctly uploaded at https://github.com/seisman/pygmt/releases/tag/v0.3.2. |
Cool, great work @seisman! This new workflow needs to be documented in maintenance.md. Also, do we want these baseline images stored on Zenodo too? If so, we'll need to update the PyGMT 'how to release' documentation too. |
Done in dc30267.
Does it mean we (mainly you) have to manually upload the zip archive to Zenodo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we want these baseline images stored on Zenodo too? If so, we'll need to update the PyGMT 'how to release' documentation too.
Does it mean we (mainly you) have to manually upload the zip archive to Zenodo?
Yes, I'll need to upload it to Zenodo. Maybe also change:
- the note at https://github.com/GenericMappingTools/pygmt/blob/master/doc/maintenance.md#archiving-on-zenodo to say "Grab both the source code and baseline images zip files from the GitHub release page and upload them to Zenodo using the previously reserved DOI".
- The last 'Release' bullet point at https://github.com/GenericMappingTools/pygmt/blob/master/.github/ISSUE_TEMPLATE/release_checklist.md to say "Manually upload the pygmt-vX.Y.Z.zip and baseline-images.zip files to ..."
Co-authored-by: Meghan Jones <[email protected]>
…appingTools#1317) * Add a workflow to upload baseline images as a release asset * Add the new workflow to maintenance.md Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Meghan Jones <[email protected]>
Description of proposed changes
In this PR, a workflow is added to upload all baseline PNG images as a release
asset when a release is published.
Fixes #1201.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version