Update fig.solar baseline images for GMT 6.2.0rc1 #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added imagesModified images
Report last updated at commit 0b9544c |
|
Four tests are still failing, off by a few pixels https://github.com/GenericMappingTools/pygmt/pull/1232/checks?check_run_id=2414751280#step:11:611: ____________________________ test_solar_terminators ____________________________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_terminators/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_terminators/result.png
________ test_solar_set_terminator_datetime[terminator_datetime_string] ________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime_string/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime_string/result.png
___________ test_solar_set_terminator_datetime[terminator_datetime1] ___________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime1/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_set_terminator_datetime_terminator_datetime1/result.png
________________________ test_solar_default_terminator _________________________
Error: Image dimensions did not match.
Expected shape: (892, 1836)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_default_terminator/baseline.png
Actual shape: (893, 1947)
/home/runner/work/pygmt/pygmt/tmp-test-dir-with-unique-name/results/pygmt.tests.test_solar.test_solar_default_terminator/result.png |
|
@seisman, I'll push a commit to mark the failing |
Merged
Yes, please. |
weiji14
approved these changes
Apr 30, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…s#1232) * Mark fig.solar tests with xfail Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Address #1217
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version