-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Figure.grdcontour tests to dvc #1158
Conversation
Related to #1131.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)
Report last updated at commit 6cef3e4 |
Quick comment: |
Noticed that, will change it, thanks @seisman. |
pygmt/tests/test_grdcontour.py
Outdated
|
||
|
||
@pytest.mark.mpl_image_compare | ||
def test_grdcontour_file(): | ||
def test_grdcontour_file(grid): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test check if grdcontour works for a grid file input, so shouldn't be changed to grid
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Rechanged it.
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Related to #1131.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version