Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Figure.grdcontour tests to dvc #1158

Merged
merged 9 commits into from
Apr 2, 2021
Merged

Migrate Figure.grdcontour tests to dvc #1158

merged 9 commits into from
Apr 2, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Related to #1131.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the maintenance Boring but important stuff for the core devs label Apr 1, 2021
@michaelgrund michaelgrund added this to the 0.4.0 milestone Apr 1, 2021
@michaelgrund michaelgrund marked this pull request as draft April 1, 2021 14:08
@michaelgrund michaelgrund added the skip-changelog Skip adding Pull Request to changelog label Apr 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_grdcontour.png
added pygmt/tests/baseline/test_grdcontour_file.png
added pygmt/tests/baseline/test_grdcontour_interval_file_full_opts.png
added pygmt/tests/baseline/test_grdcontour_labels.png
added pygmt/tests/baseline/test_grdcontour_slice.png

Image diff(s)

  • pygmt/tests/baseline/test_grdcontour.png

  • pygmt/tests/baseline/test_grdcontour_file.png

  • pygmt/tests/baseline/test_grdcontour_interval_file_full_opts.png

  • pygmt/tests/baseline/test_grdcontour_labels.png

  • pygmt/tests/baseline/test_grdcontour_slice.png

Report last updated at commit 6cef3e4

@seisman
Copy link
Member

seisman commented Apr 1, 2021

Quick comment: pygmt/tests/baseline/test_grdcontour.png should be removed.

@michaelgrund
Copy link
Member Author

Quick comment: pygmt/tests/baseline/test_grdcontour.png should be removed.

Noticed that, will change it, thanks @seisman.

@michaelgrund michaelgrund changed the title WIP: Migrate Figure.grdcontour tests to dvc Migrate Figure.grdcontour tests to dvc Apr 2, 2021
@michaelgrund michaelgrund marked this pull request as ready for review April 2, 2021 07:28


@pytest.mark.mpl_image_compare
def test_grdcontour_file():
def test_grdcontour_file(grid):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test check if grdcontour works for a grid file input, so shouldn't be changed to grid.

Copy link
Member Author

@michaelgrund michaelgrund Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Rechanged it.

@seisman seisman merged commit 2893798 into master Apr 2, 2021
@seisman seisman deleted the test-grdcontour-dvc branch April 2, 2021 18:50
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants