Rename tutorial.py to samples.py #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #1101 here's a PR to rename ``tutorial.py`` (in which functions are defined to load sample data from the GMT tutorials) to ``samples.py``.
5 tasks
seisman
requested changes
Mar 23, 2021
seisman
added
the
final review call
maxrjones
approved these changes
Mar 23, 2021
weiji14
approved these changes
Mar 23, 2021
|
I think we can just merge this as is without waiting, so that the load fracture sample data PR at #1101 can move forward. @michaelgrund has been very patient with wrapping the Can you merge this PR in by yourself @michaelgrund once all the tests pass? Just need to click on the green 'Squash and Merge' button, and make sure to tidy up the commit message a bit (describe what was done in this PR and remove unnecessary lines like '* updated |
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
* Rename tutorial.py to samples.py Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
As discussed in #1101 here's a PR to rename
tutorial.py(in which functions are defined to load sample data from the GMT tutorials) tosamples.py.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version