-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing an array as intensity for plot3d #1109
Merged
seisman
merged 8 commits into
GenericMappingTools:master
from
core-man:array-intensity-plot3d
Mar 24, 2021
Merged
Allow passing an array as intensity for plot3d #1109
seisman
merged 8 commits into
GenericMappingTools:master
from
core-man:array-intensity-plot3d
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Mar 23, 2021
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Mar 23, 2021
seisman
reviewed
Mar 23, 2021
Co-authored-by: Dongdong Tian <[email protected]>
seisman
approved these changes
Mar 23, 2021
seisman
reviewed
Mar 24, 2021
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
) Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Currently, we can have two ways to specify an intensity/intensities using the plot3d method.
intensity=0.5
, which works for bothx
/y
/z
anddata
input. This is similar to-I0.5
in the GMT command line.intensity=True
, and read intensities from an input file or from a 2D array, which is only for thedata
parameter. This is similar to-I
in the GMT command line.So, when we want to change the intensities for different points, we can only use the
data
parameter now. This PR tries to pass an array tointensity
so that we can set different intensities when we usex
/y
/z
as point input. This way will not work fordata
input.Related to #891
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version