Let Figure.show(method='external') work well in Python scripts #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
reviewed
Mar 15, 2021
Comment on lines
+224
to
+226
| # suspend the execution for 0.5 s to avoid the images being deleted | ||
| # when a Python script exits | ||
| time.sleep(0.5) |
There was a problem hiding this comment.
Instead of using time.sleep, could we change the subprocess.run to be blocking? I.e. ensure that the subprocess run is completed before continuing to exit the function.
There was a problem hiding this comment.
I tried a few ways but still can't make it blocking.
There was a problem hiding this comment.
Do you think time.sleep is better than using subprocess.Popen(...).wait()?
There was a problem hiding this comment.
subprocess.Popen(...).wait()
Unfortunately, changing subprocess.call to subprocess.Popen(...).wait() doesn't work at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See #1061 for context.
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version