Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "GitHub Actions" subsection heading from MAINTENANCE.md #1058

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 14, 2021

Description of proposed changes

  • The only CI service we're using is "GitHub Actions", so no need to have the "GitHub Actions" subsection
  • Fix a typo in markdown foramt

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 14, 2021
@seisman seisman added this to the 0.3.1 milestone Mar 14, 2021
@seisman seisman requested a review from weiji14 March 14, 2021 06:41
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please change the title to something else. There's a lot of 'tiny' changes recently. Maybe 'Remove GitHub Actions subsection in MAINTENANCE.md'?

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me!

@weiji14 weiji14 modified the milestones: 0.3.1, 0.4.0 Mar 14, 2021
@seisman seisman changed the title Tiny improvements to MAINTENANCE.md Remove the "GitHub Actions" subsection heading from MAINTENANCE.md Mar 14, 2021
@seisman seisman merged commit 1fb9e2e into master Mar 15, 2021
@seisman seisman deleted the maintenance branch March 15, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants