Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the title for the images/EPS on maps gallery example #1052

Merged
merged 4 commits into from
Mar 13, 2021

Conversation

core-man
Copy link
Member

Description of proposed changes

Update the title for the images/EPS on maps gallery example (Originally posted in #995 (comment))

By the way, shall we rename this gallery to something like Images or EPS files on figures since we can put them on any figure instead of only a map, right?

Sounds good. Actually, Figure.image() can recognize most image formats (png, jpg, eps, pdf et al.) via GDAL. So I think we could just say "Put images on figures" or similar.

A tiny improvement is also added for the comment of position argument.

Related to #983 and #996.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

examples/gallery/images/image.py Outdated Show resolved Hide resolved
examples/gallery/images/image.py Outdated Show resolved Hide resolved
@seisman seisman added this to the 0.3.1 milestone Mar 13, 2021
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 13, 2021
@seisman seisman merged commit c4117cd into GenericMappingTools:master Mar 13, 2021
@core-man core-man deleted the image-gallery branch March 13, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants