Figure.plot3d: Deprecate parameter "columns" to "incols" (remove in v0.6.0) #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxrjones
reviewed
Mar 12, 2021
|
@willschlitzer please see my comments at #764 (comment). |
Co-authored-by: Meghan Jones <[email protected]>
|
Converting to draft to hold off until v0.4.0 |
Closed
7 tasks
5 tasks
|
Ping @willschlitzer to work on this issue if available. |
I'm planning on working on this when I get back home on June 14. |
|
I have updated this per the comments in #764 and changed |
Co-authored-by: Michael Grund <[email protected]>
maxrjones
reviewed
Jun 15, 2021
seisman
reviewed
Jun 15, 2021
weiji14
changed the title
maxrjones
reviewed
Jun 16, 2021
seisman
reviewed
Jun 16, 2021
Co-authored-by: Meghan Jones <[email protected]>
weiji14
approved these changes
Jun 17, 2021
maxrjones
approved these changes
Jun 17, 2021
seisman
approved these changes
Jun 17, 2021
seisman
changed the title
6 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…0.6.0) (GenericMappingTools#1040) * Add "incols" parameter in plot3d.py * change data accepted types to include table-like * add @deprecate_parameter for columns parameter * add test for deprecated "columns" parameter in plot3d Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Michael Grund <[email protected]> Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed by @weiji14, this is to add the parameter description for
incolsinplot3d.py.Fixes #764
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version