Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add underscore guideline to CONTRIBUTING.md #1034

Merged
merged 5 commits into from
Mar 12, 2021
Merged

Add underscore guideline to CONTRIBUTING.md #1034

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fec79a
Add guideline that new files should have hyphens, not underscores
willschlitzer Mar 10, 2021
9300857
Update CONTRIBUTING.md
willschlitzer Mar 11, 2021
5172c49
Update CONTRIBUTING.md
willschlitzer Mar 11, 2021
f3e588b
Merge branch 'master' into hyphen-guidelines
willschlitzer Mar 12, 2021
e9102b3
Include directories to use underscores
willschlitzer Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ General guidelines for pull requests (PRs):
* Larger changes should be broken down into smaller components and integrated
separately.
* Bug fixes should be submitted in separate PRs.
* Use underscore for all Python (*.py) files as per [PEP8](https://www.python.org/dev/peps/pep-0008/), not hyphens
willschlitzer marked this conversation as resolved.
Show resolved Hide resolved
* Describe what your PR changes and *why* this is a good thing. Be as specific as you
can. The PR description is how we keep track of the changes made to the project over
time.
Expand Down