Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gallery example showing different front styles #1022

Merged
merged 21 commits into from
Mar 12, 2021

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Mar 8, 2021

Here's another gallery example to highlight the indiviudal front styles one can use with PyGMT. Documentation is now added.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Here's another gallery example to highlight the indiviudal front styles one can use with PyGMT.
@michaelgrund michaelgrund marked this pull request as draft March 8, 2021 19:09
@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Mar 8, 2021
@michaelgrund michaelgrund added this to the 0.3.1 milestone Mar 8, 2021
@michaelgrund
Copy link
Member Author

/format

@michaelgrund michaelgrund requested a review from a team March 10, 2021 18:04
examples/gallery/line/linefronts.py Outdated Show resolved Hide resolved
examples/gallery/line/linefronts.py Outdated Show resolved Hide resolved
examples/gallery/line/linefronts.py Outdated Show resolved Hide resolved
examples/gallery/line/linefronts.py Outdated Show resolved Hide resolved
examples/gallery/line/linefronts.py Outdated Show resolved Hide resolved
@seisman
Copy link
Member

seisman commented Mar 12, 2021

FYI, I just merged the master branch and move the example to the lines directory.

@seisman seisman marked this pull request as ready for review March 12, 2021 15:09
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me.

@core-man
Copy link
Member

core-man commented Mar 12, 2021

Looks great~

@willschlitzer willschlitzer merged commit b1d50d0 into master Mar 12, 2021
@willschlitzer willschlitzer deleted the gallery-front-styles branch March 12, 2021 22:43
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…ools#1022)

* Add a gallery example showing different line front styles

Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Yao Jiayuan <[email protected]>
Co-authored-by: Will Schlitzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants