Reduce lack of -x to just an information messag #8319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Jan 20, 2024
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Jan 23, 2024
|
I'm getting this error when OpenMP is disabled: The reason is |
joa-quim
added a commit
that referenced
this pull request
Jun 18, 2024
…failing. Integrate the ideas of #8319
joa-quim
added a commit
that referenced
this pull request
Jun 19, 2024
* Let x option synopsis be printed in grdfilter independently of having OMP or not. * Let all 3 modules built with Glib use max number of cores by default like the OMP case. * Do not use multi-threads with -Ff (custom filter). It's broken. * Use API->n_cores instead of gmtlib_get_num_processors() to see if it pleases Mac * Do not use all cores by default in potential modules. Some tests are failing. Integrate the ideas of #8319 * Remove mention to -x option (not in current surface module). Variable filter width (grdfilter) does not support -x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8300. Just say if no parallel support then only once care will be used. However @seisman, my effort at printing that out fails (but the error is gone). Can you check why
#if !defined(GMT_MP_ENABLED)seems to fail for me? E.g., lines 9169 and 18779 in gmt_init.c