Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify items for bars should be sorted #7025

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Clarify items for bars should be sorted #7025

merged 3 commits into from
Sep 21, 2022

Conversation

PaulWessel
Copy link
Member

See #7021 for background. This PR adds some language to indicate the multiband values should be sorted if +v is used. Closes #7021.

See #7021 for backtround.  This PR adds some language to indicate the multiband values should be sorted if +v is used.  Closes #7021.
@PaulWessel PaulWessel added the documentation Improve documentation label Sep 12, 2022
@PaulWessel PaulWessel added this to the 6.5.0 milestone Sep 12, 2022
@PaulWessel PaulWessel self-assigned this Sep 12, 2022
@PaulWessel
Copy link
Member Author

@joa-quim, what can we do to avoid this "internal compiler error" shits in the CI? Id says it happens at line 6338 in gmt_support.c which is inside an old function gmtlib_detrend which I dont thin have changed, and of course you do not get these errors. Can you see anything funny in the actual command switches the CI uses in that log? It is not good that every commit triggers this failed test.

@joa-quim
Copy link
Member

I have a slightly older version of the compiler and this is telling me to not let it update. We can try reversing the order of the if else test. We could also try report this error but honestly after experience and stupid answers when I reported that sort bug that they refused to accept as a bug (C standard undefined behavior, f) I have no more patience for them.

Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side, this addition to the documentation is OK.

@PaulWessel PaulWessel merged commit b581fd5 into master Sep 21, 2022
@PaulWessel PaulWessel deleted the sort-msg branch September 21, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear bar plot (-Sb or -SB) generated by plot when only appending +v (no +s)
3 participants