-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix API case for external data passed as vectors #6521
Conversation
@PaulWessel, I found that this test uses GMT_IS_REFERENCE and crashes as-is but passes if I modify |
Yes possibly, I will give it a check tomorrow morning. |
Thanks |
I had a conceptual error in my thinking when it came to data sets being passed in via vectors and GMT_IS_REFERENCE: Since we are creating a DATASET container for the input and we set its pointers to the external arrays, we do not need to consult which columns were allocated externally or internally since all of them shall be treated as external so that when the module (here psxy) finishes it does not attempt to free any of them (even one that was allocated by GMT in main) since it will be freed at that level instead. |
See if this also fixes the original pyGMT issue, @meghanrjones . That crash is gone for me. |
Yes, the PyGMT issue is fixed. Thanks. I will need your approval on the PR before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
Description of proposed changes
This PR adds a version of the bug report from GenericMappingTools/pygmt#1691 to the C API tests. Currently crashes.
Fixes #
Reminders