-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gmt.conf.rst #4834
Update gmt.conf.rst #4834
Conversation
stopped before **IO_SEGMENT_MARKER**
Thanks for starting on this, @gd-a! For future PRs, please include a full description of the proposed changes (even if they are already detailed in an issue). I've edited the description of this PR as an example. Full descriptions in the PRs are helpful because they simplify tracking of changes and make it easier for people who get email notifications about new pull requests. The fixes #____ is particularly helpful because it enables GitHub to automatically close issues when PRs get merged into the code base. |
**Description of proposed changes** Updates the gmt.conf documentation so that the defaults values are all included in brackets and the allowed (non-numeric) values for each parameter are **bolded**. Fixes #4820 Fixes #4822 parameters in **bold** and standard format for default values `[*default is **x**]`
I think I submitted the full version |
doc/rst/source/gmt.conf.rst
Outdated
@@ -89,11 +89,11 @@ COLOR Parameters | |||
in CMYK but interpolates in RGB). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L86: change from
are: **none** (default: use whatever the **COLOR_MODEL** setting in the
to
to are **none** (use whatever the **COLOR_MODEL** setting in the
Yes, agree, 'default is' should be normal font. No point in italicize it. |
@gd-a, please replace the instances of |
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
Co-authored-by: Meghan Jones <[email protected]>
@meghanrjones : all your suggestions have been committed. |
This is great, thanks @gd-a! The only parameter that remains different from the others is COLOR_MODEL. It should be good to go after that is updated. If there's a reason why you think it should stay as is, please feel free to post. |
How do you want it ? |
See this comment: https://github.com/GenericMappingTools/gmt/pull/4834/files#r579679911 and this suggestion: https://github.com/GenericMappingTools/gmt/pull/4834/files#r579680017 |
Co-authored-by: Meghan Jones <[email protected]>
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
Description of proposed changes
Updates the gmt.conf documentation so that the defaults values are all included in brackets and the allowed (non-numeric) values for each parameter are bolded.
Fixes #4820
Fixes #4822
updated up to IO_SEGMENT_MARKER