Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial 2: Fix typos #18

Merged
merged 5 commits into from
Dec 1, 2024
Merged

Tutorial 2: Fix typos #18

merged 5 commits into from
Dec 1, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Nov 29, 2024

Some typo fixes:

  • SPEC to SPE (Looks like that "SPEC" is related to "scientific Python ecosystem Coordination", so the acronym for "scientific Python ecosystem" is only "spe" (https://scientific-python.org/specs/)
  • Pandas to pandas (always lower case)
  • aspatial to spatial (focus on the geometry of the geopandas.DataFrame)

@yvonnefroehlich yvonnefroehlich added enhancement New feature or request needs review Review of this PR is welcome labels Nov 29, 2024
@yvonnefroehlich yvonnefroehlich self-assigned this Nov 29, 2024
Copy link

gitnotebooks bot commented Nov 29, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/GenericMappingTools/agu24workshop/pull/18

@yvonnefroehlich yvonnefroehlich changed the title Tutorial 2 - Adjust filename: Renaame "spec" to "spe" Rename "spec" to "spe" Nov 30, 2024
@yvonnefroehlich yvonnefroehlich changed the title Rename "spec" to "spe" Tutorial 2: Fix typos Dec 1, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yvonnefroehlich. I did wonder a bit about the aspatial/spatial wording (we're plotting spatial polygon data, but using aspatial data to colour the polygons), probably better to call it a spatial plot since we are plotting spatial geometries. A pure aspatial plot would be something like a histogram that is not a 'map'.

@weiji14 weiji14 merged commit c2876fa into main Dec 1, 2024
1 check passed
@weiji14 weiji14 deleted the rename-tut2-spec2spe branch December 1, 2024 21:50
weiji14 added a commit that referenced this pull request Dec 1, 2024
@yvonnefroehlich
Copy link
Member Author

Thanks @yvonnefroehlich. I did wonder a bit about the aspatial/spatial wording (we're plotting spatial polygon data, but using aspatial data to colour the polygons), probably better to call it a spatial plot since we are plotting spatial geometries. A pure aspatial plot would be something like a histogram that is not a 'map'.

Yeah, I also was debating on this when creating the tutorial. There was also a comment from Michael on this regarding the slides for the PyGMT talk. Finally, I decided to use "spatial" to have the focus on handling the line and polygon geometries (actually I used "spatial" in the beginning, but I changed it later due to the aspatial parameter).

@yvonnefroehlich yvonnefroehlich removed the needs review Review of this PR is welcome label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants