-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getting started and installation instructions to the welcome page #12
Conversation
Editing the front page to include a one-click Binder link to run the Jupyter notebooks, and steps for people to get a conda virtual environment set up locally for the AGU24 pre-conference workshop. Based on EGU22 short course at GenericMappingTools/egu22pygmt#10.
Adding the 6 main tutorials as sphinx-design cards in a 3x2 grid. Each card has the tutorial title, author(s), and tags/badges. The tags hint at which libraries/methods will be covered, and also the datasets that are used.
book/intro.md
Outdated
{bdg-secondary-line}`japan_quakes` | ||
{bdg-info}`pandas` | ||
{bdg-info}`geopandas` | ||
{bdg-info-line}`airbnb` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this; I would prefer to include "choropleth map"
{bdg-info-line}`airbnb` | |
{bdg-info-line}`choropleth map` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I could use some advice on what tags/badges to add. My current thought process is to include:
- bdg-primary: pygmt or gmt
- bdg-primary-line: GMT module used (e.g.
coast
,plot
, etc) - bdg-info: External library used (e.g.
pandas
,xarray
) - bdg-secondary-line: GMT remote-dataset used (e.g.
earth_relief
,earth_age
, etc)
The {bdg-info-line}`airbnb`
here was intended to show external non GMT remote-datasets used, but I do agree that having AirBnB here looks weird. We could maybe add some tags for concepts being taught such as choropleth-map
as you suggested, or scatterplot
, etc.
Ref: color of badges/tags: https://sphinx-design.readthedocs.io/en/sbt-theme/badges_buttons.html#badges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I got your main idea behind the structure of these tags / badges and I definitely like this idea! And I think mentioning special concept / specific visualization is a good addition.
Even the file contains "airbnb" currently the column “population” is used for the choropleth-map (there are a lot of different columns / quantities in this dataset).
Co-authored-by: Yvonne Fröhlich <[email protected]>
Sort alphabetically, change `bdg-info` to `bdg-success` for more differentiation (also, unsure why primary and info colour is the same now?), and add more tags based on new tutorial updates.
Also choosing other teaser images for Tutorial 1, 2, 3.
Figure is too long, so just getting the bottom part only. Using a 75dpi version.
Remove the h2 heading and do some more sphinx-design grid nesting to squeeze out more vertical space for the thumbnail images. The grids are now adaptive too, and will turn from 3 columns to 1 column on narrow width screens (e.g. mobile devices). Ref: https://sphinx-design.readthedocs.io/en/sbt-theme/grids.html#nesting-grids.
Ok, spent way too much time on the grid layout, but this PR is finally ready for review! Screenshot of the thumbnail images on the front page: Had to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few typo fixes for now - but this looks already very nice @weiji14 🙂! Will give this PR a more detailed review later the day!
book/intro.md
Outdated
{bdg-secondary-line}`earth_age` | ||
::: | ||
|
||
:::{grid-item-card} Tutorial 2 - Integration with the Scientific Python Ecosystem: Pandas / GeoPandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:::{grid-item-card} Tutorial 2 - Integration with the Scientific Python Ecosystem: Pandas / GeoPandas | |
:::{grid-item-card} Tutorial 2 - Integration with the scientific Python ecosystem: pandas / GeoPandas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess @weiji14 try to maintain consistency across all titles by capitalizing the first letter of each word throughout the page. Maybe it's just to ensure consistency on this page or to align with the style used in EGU22?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take @yvonnefroehlich's suggestions on capitalization, we should try to match with the titles on the left side bar too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @weiji14, for working on the introduction page. This looks nice 🙂!
I personally like equal-sized cards more, at least a common horizontal line at which the upper edges of the cards of one row align. But if this is difficult to set up, we can leave the layout as is. Also for the EGU workshop, the height of the cards scales with the size of the images (please see https://www.generic-mapping-tools.org/egu22pygmt/intro.html).
Co-authored-by: Yvonne Fröhlich <[email protected]>
Yeah, so the previous EGU22 short course used I'll merge this in first, so we at least have the installation instructions on the website (and @maxrjones can send the email to the participants). If anyone has time to alter the thumbnail layout, feel free to do that (but I'm guessing there are more important things to fix before that)! |
No worries. I already thought based on the comment "spent way too much time on the grid layout" that you already tried different layouts 🙈. |
Editing the front page to include a one-click Binder link to run the Jupyter notebooks, and steps for people to get a conda virtual environment set up locally for the AGU24 pre-conference workshop.
Screenshot
TODO:
References: