Update ILiquidationSource implementation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
asselstine
approved these changes
Aug 24, 2023
asselstine
requested changes
Aug 24, 2023
src/VaultBooster.sol
Outdated
| amountAvailable = (amountAvailable - amountOut); | ||
| _boosts[IERC20(tokenOut)].available = amountAvailable.toUint144(); | ||
| _boosts[IERC20(tokenOut)].lastAccruedAt = uint48(block.timestamp); | ||
| prizePool.contributePrizeTokens(vault, amountIn); |
There was a problem hiding this comment.
You can add flash swap support here; needs a couple of things tho:
- safe transfer needs to occur first
- then if data.length > 0 you cast and call the receiver
- then contribute to the prize pool
There was a problem hiding this comment.
LCOV of commit
|
asselstine
approved these changes
Aug 27, 2023
asselstine
deleted the
gen-498-vaultbooster-using-out-of-date-liquidator-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
_flashSwapDatawas added to theliquidatefunction in the interface, but this contract does not support flash swaps so an error will be thrown if that data is not empty.