Updates to the error handling to include parameters

GeneralScripting · Feb 6, 2014 · 8d8974d · 8d8974d
1 parent e423581
commit 8d8974d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/lib/pipedrive/base.rb b/lib/pipedrive/base.rb
@@ -71,9 +71,9 @@ def authenticate(token)
       # Examines a bad response and raises an appropriate exception
       #
       # @param [HTTParty::Response] response
-      def bad_response(response)
+      def bad_response(response, params={})
         if response.class == HTTParty::Response
-          raise HTTParty::ResponseError, response
+          raise HTTParty::ResponseError, "#{response}\n params: #{params.inspect}"
         end
         raise StandardError, 'Unknown error'
       end
@@ -87,7 +87,7 @@ def all(response = nil, options={})
         if res.ok?
           res['data'].nil? ? [] : res['data'].map{|obj| new(obj)}
         else
-          bad_response(res)
+          bad_response(res,attrs)
         end
       end
 
@@ -97,18 +97,18 @@ def create( opts = {} )
           res['data'] = opts.merge res['data']
           new(res)
         else
-          bad_response(res)
+          bad_response(res,opts)
         end
       end
 
       def find(id)
         res = get "#{resource_path}/#{id}"
-        res.ok? ? new(res) : bad_response(res)
+        res.ok? ? new(res) : bad_response(res,id)
       end
 
       def find_by_name(name, opts={})
         res = get "#{resource_path}/find", :query => { :term => name }.merge(opts)
-        res.ok? ? new_list(res) : bad_response(res)
+        res.ok? ? new_list(res) : bad_response(res,{:name => name}.merge(opts))
       end
 
       def resource_path

diff --git a/lib/pipedrive/deal.rb b/lib/pipedrive/deal.rb
@@ -3,7 +3,7 @@ class Deal < Base
 
     def add_product(opts = {})
       res = post "#{resource_path}/#{id}/products", :body => opts
-      res.success? ? res['data']['product_attachment_id'] : bad_response(res)
+      res.success? ? res['data']['product_attachment_id'] : bad_response(res,opts)
     end
 
     def products
@@ -12,7 +12,7 @@ def products
 
     def remove_product product_attachment_id
       res = delete "#{resource_path}/#{id}/products", { :body => { :product_attachment_id => product_attachment_id } }
-      res.success? ? nil : bad_response(res)
+      res.success? ? nil : bad_response(res,product_attachment_id)
     end
 
     def activities

diff --git a/lib/pipedrive/pipeline.rb b/lib/pipedrive/pipeline.rb
@@ -7,7 +7,7 @@ def stages
     def statistics(id, start_date, end_date)
       res = get("#{resource_path}/#{id}/movement_statistics",
                 :query => {:start_date => start_date, :end_date => end_date})
-      res.ok? ? new(res) : bad_response(res)
+      res.ok? ? new(res) : bad_response(res,{:id=>id,:start_date=>start_date,:end_date=>end_date})
     end
 
     def deals(id, stage_id)

diff --git a/lib/pipedrive/search-result.rb b/lib/pipedrive/search-result.rb
@@ -9,7 +9,7 @@ def search(term, start=0, limit=nil)
         if res.ok?
           res['data'].nil? ? [] : res['data'].map{|obj| new(obj)}
         else
-          bad_response(res)
+          bad_response(res,{:term=>term,:start=>start,:limit=>limit})
         end
       end
 
@@ -18,7 +18,7 @@ def field(term, field_type, field_key, opts={})
         if res.ok?
           res['data'].nil? ? [] : res['data'].map{|obj| new(obj)}
         else
-          bad_response(res)
+          bad_response(res,{:term=>term,:field_type=>field_type,:field_key=>field_key},merge(opts))
         end
       end