avoid infinite loop when dead proxy is passed via requests_args #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avant1
force-pushed
the
avoid-infinite-loop
branch
from
72be67c to
37b4494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dead proxy is passed via
request_args,TrendReq.GetGoogleCookie()will loop infinitely in attempt to execute request.This is not very useful by itself, and also contradicts handling of proxies passed via
proxiesparameter (in that case all proxies are checked, and error is thrown in case if all proxies are dead).As for backward compatibility, I think this patch doesn't change much. Only one proxy can be passed via
request_args, so when given proxy works only 50% of the time, it will likely fail during subsequent requests.