Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge constr vrestor #770

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Charge constr vrestor #770

merged 5 commits into from
Nov 18, 2024

Conversation

qluo0320github
Copy link
Collaborator

@qluo0320github qluo0320github commented Sep 11, 2024

Description

What type of PR is this? (check all applicable)

  • Bug Fix

Related Tickets & Documents

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • Code has been tested to ensure all functionality works as intended.
  • CHANGELOG.md has been updated (if this is a 'notable' change).
  • I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Can be tested with the original VRE_STOR example case

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

Repository owner deleted a comment from github-actions bot Nov 14, 2024
@lbonaldo lbonaldo force-pushed the charge_constr_vrestor branch from aebd6de to a60a6d0 Compare November 18, 2024 16:48
@@ -1286,6 +1299,9 @@ function stor_vre_stor!(EP::Model, inputs::Dict, setup::Dict)
if rep_periods > 1 && !isempty(VS_LDS)
lds_vre_stor!(EP, inputs)
end

# Constraint 4: electricity charged from the grid cannot exceed the charging capacity of the storage component in VRE_STOR
@constraint(EP, [y in STOR, t = 1:T], vCHARGE_VRE_STOR[y,t] <= eCHARGE_VS_STOR[y,t])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
@constraint(EP, [y in STOR, t = 1:T], vCHARGE_VRE_STOR[y,t] <= eCHARGE_VS_STOR[y,t])
@constraint(EP, [y in STOR, t = 1:T], vCHARGE_VRE_STOR[y, t]<=eCHARGE_VS_STOR[y, t])

Copy link
Collaborator

@lbonaldo lbonaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @qluo0320github. Just rebased with current develop.

@lbonaldo lbonaldo merged commit 65e25d7 into develop Nov 18, 2024
7 of 9 checks passed
@lbonaldo lbonaldo deleted the charge_constr_vrestor branch November 18, 2024 17:01
@GenXProject GenXProject added this to the v0.4.2 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants