Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAPIS 2 docs: tailwind integration #388

Closed
chaoran-chen opened this issue Sep 20, 2023 · 0 comments · Fixed by #390
Closed

LAPIS 2 docs: tailwind integration #388

chaoran-chen opened this issue Sep 20, 2023 · 0 comments · Fixed by #390
Assignees
@fengelniederhammer
Labels
documentation Improvements or additions to documentation LAPIS Tasks/PR related to LAPIS

Comments

@chaoran-chen
Copy link
Member

When I started the LAPIS 2 documentation, starlight wasn't working very well with tailwind and I had to disable preflight and possibly implement other workarounds. I noted the following TODO: https://github.com/GenSpectrum/LAPIS/blob/a6d7377607968d47e8df86a5a81551648ff2709f/lapis2-docs/tailwind.config.cjs#L5C8-L5C90

The PR to add a Tailwind plugin in the Starlight repository has been merged in the meantime: withastro/starlight#337, so we should probably use it.

(cc @fengelniederhammer)
@chaoran-chen chaoran-chen added documentation Improvements or additions to documentation LAPIS Tasks/PR related to LAPIS labels Sep 20, 2023
@fengelniederhammer fengelniederhammer self-assigned this Sep 21, 2023
fengelniederhammer added a commit that referenced this issue Sep 21, 2023
@fengelniederhammer
chore(lapis2-docs): Use starlight integration for tailwind #388
2fe41c2 
This removes the mentioned workaround.
@fengelniederhammer fengelniederhammer mentioned this issue Sep 21, 2023
Merged
@fengelniederhammer fengelniederhammer linked a pull request Sep 21, 2023 that will close this issue
Docs: Update to Astro 3 #390
Merged
fengelniederhammer added a commit that referenced this issue Sep 21, 2023
@fengelniederhammer
chore(lapis2-docs): Use starlight integration for tailwind #388
0b1403f 
This removes the mentioned workaround.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
documentation Improvements or additions to documentation LAPIS Tasks/PR related to LAPIS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: Update to Astro 3 GenSpectrum/LAPIS
2 participants
@chaoran-chen @fengelniederhammer