Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fab button bug in production #677

Closed
yongdamsh opened this issue Mar 23, 2017 · 19 comments
Closed

Fab button bug in production #677

yongdamsh opened this issue Mar 23, 2017 · 19 comments
Assignees

Comments

@yongdamsh
Copy link

react-native, react and native-base version

react-native: 0.42
react: 15.4.2
native-base: 2.0.13

Expected behaviour

Show 'Button' component only

Actual behaviour

In iOS, It shows empty button in production(release mode)

glass

Steps to reproduce (code snippet or screenshot)

Screenshot of emulator/device

Is the bug present in both ios and android or in any one of them?

iOS (Not tested Android yet)

Any other additional info which would help us debug the issue quicker.

In this code, if app is in release mode, component's displayName is not Styled(Icon) or Styled(IconNB). It looks like Styled(o), Styled(d). So childrenArray includes Icon component.
I think it's related with minification of source code.

@charles-mutabazi
Copy link

charles-mutabazi commented Mar 23, 2017

@yongdamsh I am noticing that bug too... have you managed to fix it?

@yongdamsh
Copy link
Author

yongdamsh commented Mar 23, 2017

@charles-mutabazi

Not yet. I'm just workarounding for my project.

I changed the Fab.js file in 'node_modules/native-base/dist/src/basic' path.

  1. Comment out line 202 - 206
  2. At line 210, return a sliced childrenArray. (It's not good because it is dependant on component order)
    Change array method to childrenArray.map -> childrenArray.slice(1).map

@dekkofilms
Copy link

dekkofilms commented Mar 23, 2017

Originally I thought it is was only an issue on Android, but I do see it on production for both platforms.

but i guess that's a temporary fix for now, but would love to know if this gets resolved soon! thanks, @yongdamsh

@felipemartim
Copy link

felipemartim commented Mar 28, 2017

@yongdamsh's workaround solved the issue for me on both Android and iOS.

@obykoo
Copy link

obykoo commented Apr 5, 2017

Thanks it solved this problem, you should make pull request or wait for them to fix it

@JLLLinn
Copy link

JLLLinn commented May 1, 2017

This is happening to me too. Can we get this fix in release?

@emilioicai
Copy link

This is preventing my team to release any app including native-base to production. Is this being taken care of?

@bmoreira10
Copy link

I tried that workaround and it didn't work , the random blue circle is still there...

@SupriyaKalghatgi
Copy link
Contributor

@yongdamsh Thank you for bringing this to our notice. You can send a PR to this with proper use cases and description.
@JLLLinn @emilioicai We will look into this

@saiprasad1996
Copy link

is the bug solved? facing the same issues. The blue circle appear in release builds only but not in the debug build.

@SupriyaKalghatgi
Copy link
Contributor

We are looking into this

@BrunoQuaresma
Copy link

Still with the problem here.

@shivrajkumar
Copy link
Collaborator

@BrunoQuaresma Did you try with the above commit?

@saiprasad1996
Copy link

@shivrajkumar is the commit included in the latest npm install ??

@shivrajkumar
Copy link
Collaborator

shivrajkumar commented Jun 7, 2017

@saiprasad1996 It will be included in the next patch.

@hewrin
Copy link

hewrin commented Jun 8, 2017

Just to confirm, version 2.1.4 doesn't have the commit that fixed this?

@shivrajkumar
Copy link
Collaborator

No, It will be released by end of this week or next week.

@sankhadeeproy007
Copy link
Contributor

Fixed with 2.1.5

@saiprasad1996
Copy link

Great team !! Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests