Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests and small code cleanup. #771

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Added unit tests and small code cleanup. #771

merged 2 commits into from
Aug 11, 2024

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Aug 10, 2024

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Aug 10, 2024

PR Summary

  • Addition of new documentation blocks in class-export.php file
    This includes tags indicating when the changes were made.

  • Inclusion of a new 'render' method in class-export.php file
    Improved documentation is provided for this new feature showing when it was introduced.

  • Removal of unused imports in class-import.php file
    These imports were no longer necessary and their removal streamlines the code.

  • Modification of 'export_callback' and 'import_callback' values in the class-migrate.php file
    This update improves efficiency in the gathering and migration process.

  • Creation of new test files
    The new 'class-test-export.php', 'class-test-import.php', and 'class-test-migrate.php' files will help to validate that the system is working correctly.

@carstingaxion
Copy link
Collaborator

Yeah, ignoring the wrong decoded site-title, this seems to work.

IMG_0199

@mauteri
Copy link
Contributor Author

mauteri commented Aug 10, 2024

@carstingaxion I also discovered some things we should add to distignore. Updated PR with those. Your zip file helped me discover it :-D

Copy link

Preview changes with Playground

You can preview the least recent changes for PR#771 by following one of the links below:

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@mauteri
Copy link
Contributor Author

mauteri commented Aug 10, 2024

Hmmmm, still showing test and jest.config.js...

Screenshot 2024-08-10 at 7 58 23 PM

@mauteri mauteri merged commit 188c441 into main Aug 11, 2024
13 checks passed
@mauteri mauteri deleted the mauteri-unit-test branch August 11, 2024 00:01
@carstingaxion
Copy link
Collaborator

carstingaxion commented Aug 11, 2024

Maybe this line within the checkout step could be the problem:

This should be github.head_ref I guess.

@carstingaxion
Copy link
Collaborator

Maybe this line within the checkout step could be the problem:

This has been another can of worms, but at least this step number 147 is taken now too. Let’s see how far we can get. I illustrated my last test-PR #775 with some screenshots, to show that the checkout grabs the correct ref before doing the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants