Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix public requests of shadow venue taxonomy. #677

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Fix public requests of shadow venue taxonomy. #677

merged 1 commit into from
Jun 7, 2024

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Jun 7, 2024

Description of the Change

Sets rewrite to false when registering venue shadow taxonomy.

Closes #676

How to test the Change

Changelog Entry

Fixed - Bug fix

Credits

Props @mauteri, @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Jun 7, 2024

PR Summary

  • Taxonomy Registration Modification in class-venue.php
    The method to register taxonomy in the file class-venue.php was amended. It now includes an additional parameter titled rewrite, set as false. This prevents any changes to the URLs, adding stability and predictability to how our system generates and manages links linked to this taxonomy.

@mauteri mauteri merged commit 46ddc6e into main Jun 7, 2024
11 checks passed
@mauteri mauteri deleted the GP-676 branch June 7, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disallow public requests to .../_gatherpress_venue/TERMNAME/
1 participant