feat(DS): update styles for images on pin modal and change html for social buttons #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miffael
requested review from
korel-san,
AntonOlkhovskyi,
buchslava and
vdmchpg
|
Can't check on branch at home. Need to merge to the Dev env |
Miffael
pushed a commit
that referenced
this pull request
Oct 26, 2018
test(*): fix imagePreview loager to make tests pass, fix getRandom func fix(DS): update guide translations and hover street home on change filters (#1294) feat(DS): update header structure and styles, clear header position and size from javascript, add style for that, remove dependency from device type, left only media points (#1296) feat(DS): update quick guide position for new header structure work (#1297) fix(DS): update link in main menu (#1298) fix(DS): fix main-menu link (#1299) fix(DS): update matrix view block dom structure for change display description (#1300) feat(ds): add method to separate full family info to pharagraphs (#1301) fix(street): fix hide poorest label on mobile Guide and translation (#1304) * fix(DS): update logo button reset function for reset visibility quick guide and it doesn't reset selected languade * bed * fix(DS): add translation for income Month, on matrix and family pages * fix(DS): add translation for header family page Update chages prod (#1307) * fix(DS): fix upload home data without description * fix(DS): add delay for the scroll on bottom page elements when appearing matrix view block feat(ds): add config for deploy e2e test update for stabilization. MatrixPage po locators update. FamilyPage constructor update for stability. Share front update (#1314) * fix(DS): update float footer and share popup style and html, refactor float-footer and matrix components * feat(DS): update dividers position on street, and update steet filter component for new position dividers and drag dividers test(*): fix e2e test stability for headless chrom. test(*): add new tests fix(DS): fix dividers on results outside filters sets and hide float footer for langscape small devices (#1318) Street multi dividers (#1319) * feat(DS): add new dividers any count and update dividers income for work with time unit * feat(DS): add timeUnit dependency for street dividers test(*): updat e2e for stability on CI test(e2e):Update disabled tests for Matrix Page fix(DS): update position street line on capture image for share from share modal (#1323) test(e2e): add new checks for Embed last screen test(e2e):add new tests for twitter Update travis file (#1335) * feat(ds):add-travis-deploy * feat(ds):fix-travis-deploy * feat(ds):fixed-travis-deploy fix(DS): add the updating income on change the income filter for the matrix detail block (#1336) test(e2e):share via facebook feat(DS): change default mobile zoom on matrix page (#1338) feat(DS):add translation keys to Income popup (#1340) feat(DS): move embed share button from footer to main menu (#1339) test(e2e):Update embed test to follow code style guide fefeat(DS):add translation kye to create comparison (#1343) test(conf): Update travis conf, fix protractor conf Daily income translation (#1347) * fix(DS): update daily income key for translation * fix(DS): update style for matrix image block component - update income time text to lowercase test(e2e): Add new Map page tests for markers and side menu Wrong page or parameters (#1344) * fix(DS): add reset parameters and redirect if wrong parameterst or unknown page * fix(DS): add redirect if come to family page with wrong place ID Refactoring matrix (#1348) * ref(DS): refactoring matrix module * ref(DS): move hover place subject to matrix service test(e2e):Add fwe new tests for Map Page Analitics global tag (#1352) * feat(DS): update analitics to global tag manager * feat(DS): add google analytics to share buttons in menu and footer * fix(DS): add analitics without global site tag and declare function ga() * fix(DS): remove commented code and change analitics id to live Facebook share precache (#1353) * feat(DS) add facebook pre cache images * fix(DS): add translations for share twitter test(e2e): add additional checks for Team Page test(e2e): Add new test for About Page feat(DS): add comparison image size and add push it to database (#1355) Remove facebook pre cashe request (#1356) * feat(DS): remove pre cache request * ferat(DS): change google analytics key for dev enviroment feat(DS): select 'by income' render out of dropdown work 'by' and add translation for they (#1362) test(e2e): minor data update for test support fix( DS-95 ): update static text in meta data for share in social network (#1366) fix( DS-88 ): add preload script for a wait until load images… (#1365) * fix( DS-88 ): add preload script for wait until load images which need for take screenshot for preview on facebook share post * fix( DS-88 ): update script on Promise all * fix( DS-88 ): update for build * update ( DS-88 ): add background for images which not uploaded for screenshot * fix( DS-88 ): remove condition for second resolve promise fix( DS-55 ): update income popup, changes in design and change texts, and key translations, dusable currency select (#1367) fix( DS-88 ): disable add images after start share proccessing (#1368) Embed new design (#1369) * feat( DS-60 ): updated design for comparison popup and images grid feat(DS-58): update text -create a comparison- and remove symbols (#1371) fix( DS-57 DS-102 DS-60 ) update embed popup and image grid and street component design (#1370) * fix( DS-57 DS-102 DS-60 ) update embed popup and image grid and street component design * feat(DS-102 DS-57): update font sizes and chenge plus to check mark on images grid * fix(DS): update e2e tests * feat(DS-60): left text on comparison images in two row * feat( DS-60 ): set same line height in embed popup like in image grid * feat(DS-60): move up income on street line, update colors comparison in image grids * feat(DS): update style for shate text in main menu fix(DS):fix issue when home doesn't have house image (#1372) fix( DS-101 ): remove shadow on text on the screenshot for share image (#1373) * fix(DS): remove shadow on text on the screenshot for shate image feat( DS-104 ): set font size smaler in matrix images (#1374) Puppeteer (#1377) 'feat(DS): turn on social network buttons (#1378) feat(DS): update styles for images on pin modal and change html for social buttons (#1379) feat(DS): change calculation offset for pin contaienr (#1380) feat(DS): close quick guide when open create comparison modal (#1381) feat(DS): add separate link for the download image and style for that (#1382) feat(DS): increace header size for the image on preview in social networks (#1383) feat(DS): increace text header for share to social network (#1384) fix(DS): fix matrix pages without homes (#1385) feat(DS): fix adding more then max places in pin mode, remove description for google plus share, and update styles for pin container (#1386) feat(DS): set street width same like images wudth, hide social button… (#1376) * feat(DS): set street width same like images wudth, hide social buttons, fix screenshot size * feat(DS): update styles - add max width for pin images before the share proccessing fix(DS): fix title size for matrix image block and set fixed size for pinned images for embed before complete creating the comparison fix(DS): fix title size for matrix image block and set fixed size for pinned images for embed before complete creating the comparison (#1387) feat(DS): remove specific position sliders in street component (#1388) feat(DS): move sliders back on street (#1389) tetest(e2e): disable embed and footer test, fix test according to DB changes. delete package lock feat(DS-59): hide float footer (#1375) * feat(DS-59): hide float footer * fix(DS): turn off test of float footer * feat(DS): remove float footer Facebook preview images (#1391) * feat(DS): increase image size for preview when only 2 homes Ui updates (#1390) * fis(DS-123): update style for the home detail view on matrix page * feat(DS): add listener for url parameter for scroll to row and place on matrix page * feat(DS): family block scroll position * feat(DS): fix tests * feat(DS): update scroll on matrix page * feat(DS): add adition height when we have quick guide opened * feat(DS): add after view init * feat(DS): add delay to scroll to component for wait the uploading data from separate component in the header of the Family page feat(DS): update styles for donate buttons and move down zoom buttons (#1392) feat(DS): add space to top of hedaer logo in embed popup (#1393) feat(DS): add space on the top of image (#1394) fix(DS): refactoring creations query for request embed set (#1395) feat(DS): fix position text when category doesn't have icon (#1396) * feat(DS): fix position text then category doesn't have icon * fix(DS): add check for category icons on the family page - in the family detail block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.