feat: add k8sattributes in collector mode #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
approved these changes
Oct 7, 2022
sandipndev
added a commit
that referenced
this pull request
Oct 11, 2022
This reverts commit 2772ffe.
bodymindarts
pushed a commit
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of testing, but have a good feeling about this.
Following the documentation, we need the cluster roles attached to the collector along with specifying which metadata to extract and pod_association resource attributes.
Those things have been added in this PR.
(Aside) Locally, no
k8sdata gets pushed to Honeycomb, which is strange. Maybe k3d doesn't have integrations?