fix!: bastion internet access needs nat #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
approved these changes
Jul 15, 2022
sandipndev
changed the title
fireballpoint1
pushed a commit
to fireballpoint1/galoy-infra
that referenced
this pull request
Aug 8, 2022
Moves NAT from Platform to Inception. Migration Logic: ``` # Inception terraform import module.inception.google_compute_router.router <id> terraform import module.inception.google_compute_router_nat.main <id> # Platform terraform state rm module.platform.google_compute_router.router terraform state rm module.platform.google_compute_router_nat.main ``` BREAKING CHANGE: To give proper internet access to bastion (so that metadata: startup-script works), the bastion must be created with NAT and Router present on the VPC. This should happen on the inception phase, earlier it was happening at platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like without external IP on the VPC, to give Internet access to the bastion (which lets the startup script run properly) we need the NAT.
https://serverfault.com/questions/947970/google-compute-engine-trouble-accessing-internet-from-an-instance-without-exter
Moved the NAT from platform to inception.
Tested locally and working!
My assumption is there was some race condition between GCE running the startup script and platform applying the NAT which is why on the CI it was not reliably failing?