Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Azure bootstrap service principle roles #61

Merged
merged 6 commits into from
Jul 8, 2022

Conversation

fireballpoint1
Copy link
Contributor

No description provided.

@sandipndev
Copy link
Member

Need to verify if the provided roles are enough for the service principle to run inception.

Copy link
Member

@sandipndev sandipndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the commented code block.

modules/bootstrap/azure/service-principal.tf Outdated Show resolved Hide resolved
@fireballpoint1 fireballpoint1 marked this pull request as ready for review July 8, 2022 10:58
@sandipndev sandipndev merged commit 1989dc9 into GaloyMoney:main Jul 8, 2022
fireballpoint1 added a commit to fireballpoint1/galoy-infra that referenced this pull request Aug 8, 2022
* test spn creation for running inception

* fix spn creation for app reg

* fix spn creation for app reg

* fix spn scope arguments

* longer app secret expiry

* removed unused comment block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants