Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix solver versions #180

Merged
merged 27 commits into from
Apr 11, 2022
Merged

Fix solver versions #180

merged 27 commits into from
Apr 11, 2022

Conversation

kquick
Copy link
Member

@kquick kquick commented Jan 12, 2022

Runs tests using various fixed versions of the supported solvers.

This now runs all tests against specific revisions of solvers, and will let us expand the set of revisions in the future as needed. For many of the solvers, this also establishes a "lower limit" to the supported version; if it was important to show support for earlier versions of any of these solvers we could do so, but it would mean additional controls over which tests were run, and so that didn't seem worth it at the present time unless specific needs can be identified.

Overall, this will help us maintain a compatibility matrix and also identify any regressions that occur in the future.

@kquick kquick force-pushed the fix_solver_versions branch from b1f764f to 8fc3707 Compare January 12, 2022 15:54
@kquick kquick force-pushed the fix_solver_versions branch from 42f3382 to 43a6bda Compare January 12, 2022 21:48
@kquick kquick force-pushed the fix_solver_versions branch from 43a6bda to b838956 Compare January 12, 2022 21:57
@kquick kquick force-pushed the fix_solver_versions branch 3 times, most recently from 24c7a05 to 0534afc Compare January 13, 2022 04:39
@kquick kquick force-pushed the fix_solver_versions branch from 0534afc to 5d0467a Compare January 13, 2022 05:31
@kquick kquick force-pushed the fix_solver_versions branch from a6de8a7 to 414e053 Compare January 13, 2022 23:44
README.md Show resolved Hide resolved
@kquick kquick marked this pull request as ready for review January 14, 2022 22:44
.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@robdockins robdockins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this Kevin. I think it's a great step in the right direction. My only concern is the operational one where we are sometimes running into rate-limiting for the build servers. I don't know what the right approach to that is. Maybe only run the full matrix daily rather than on every commit?

@robdockins
Copy link
Contributor

@kquick, is there any reason not to merge this while we continue to consider better ways to specify the matrix?

@kquick
Copy link
Member Author

kquick commented Mar 28, 2022

Generally no. I don't think the JSON approach is too difficult though, I just hadn't had any time to work on this. Since there's a conflict though I'll sign up to resolve the conflict and add the JSON approach by next Monday (if you wanted to merge before then please feel free to).

@robdockins
Copy link
Contributor

No urgency here, I just didn't want this to bitrot.

@kquick kquick force-pushed the fix_solver_versions branch from b750378 to ebd703c Compare April 5, 2022 05:40
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! I'm much happier with the way the CI matrix is handled now. I've left some minor suggestions/questions on the .pl script.

.github/workflows/gen_matrix.pl Show resolved Hide resolved
.github/workflows/gen_matrix.pl Outdated Show resolved Hide resolved
.github/workflows/gen_matrix.pl Outdated Show resolved Hide resolved
@kquick
Copy link
Member Author

kquick commented Apr 5, 2022

@robdockins I think this is ready for a final review now.

@kquick
Copy link
Member Author

kquick commented Apr 11, 2022

Thanks for working on this Kevin. I think it's a great step in the right direction. My only concern is the operational one where we are sometimes running into rate-limiting for the build servers. I don't know what the right approach to that is. Maybe only run the full matrix daily rather than on every commit?

This latest version that uses the generated matrix is more efficient (it will vary multiple solvers in a single run since the tests are independent for each). I haven't seen any rate limiting issues in this more recent configuration, but I think the new generator will give us the ability to add customization over time of day or other parameters in the future if needed.

@kquick kquick merged commit 5dca5cf into master Apr 11, 2022
@kquick kquick deleted the fix_solver_versions branch April 11, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants