Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please support versions >= 6.0.1 #240

Closed
swt2c opened this issue Oct 10, 2023 · 7 comments · Fixed by #241
Closed

Please support versions >= 6.0.1 #240

swt2c opened this issue Oct 10, 2023 · 7 comments · Fixed by #241

Comments

@swt2c
Copy link

swt2c commented Oct 10, 2023

Debian is updating to GHC 9.4 and LTS 21.9. This brings in versions == 6.0.1, which isn't compatible with what4. Could you add support for versions >= 6.0.1?
RyanGlScott added a commit that referenced this issue Oct 10, 2023
@RyanGlScott
Allow building with versions-6.0.*
69e3f34 
`versions-6.0.*` removes the `VChunk` data type, which `what4` defines an
orphan `Lift` instance for. This requires some CPP to fix up. This is somewhat
messy, and in an ideal world, we'd move these orphan instances directly to the
`versions` library. (See also fosskers/versions#68.)

Fixes #240.
@RyanGlScott RyanGlScott mentioned this issue Oct 10, 2023
Merged
RyanGlScott added a commit that referenced this issue Oct 10, 2023
@RyanGlScott
Allow building with versions-6.0.*
0489772 
`versions-6.0.*` removes the `VChunk` data type, which `what4` defines an
orphan `Lift` instance for. This requires some CPP to fix up. This is somewhat
messy, and in an ideal world, we'd move these orphan instances directly to the
`versions` library. (See also fosskers/versions#68.)

Fixes #240.
@swt2c
Copy link
Author

swt2c commented Oct 10, 2023

Thanks for the quick fix!

@RyanGlScott
Copy link
Contributor

No problem. Let me know if you need a Hackage release with these changes. Otherwise, I will wait until the next scheduled what4 release before doing so.

@swt2c
Copy link
Author

swt2c commented Oct 10, 2023

No problem. Let me know if you need a Hackage release with these changes. Otherwise, I will wait until the next scheduled what4 release before doing so.

If the next scheduled release is a ways off (and it's not too much work on your part to make a release), a Hackage release would be appreciated.

@RyanGlScott
Copy link
Contributor

I think I'll wait just a bit longer before making a new what4 release, since a fix to fosskers/versions#68 is imminent and will require a further update on what4's end.

@fosskers
Copy link

fosskers commented Oct 12, 2023 •
edited
Loading

versions updated and released as 6.0.2.

RyanGlScott added a commit that referenced this issue Oct 12, 2023
@RyanGlScott
Require versions >= 6.0.2
00b18ec 
`versions-6.0.2` introduces a `Lift Version` instance, which finally allows us
to delete the ugly, CPP'd mess of orphan instances that we define in
`What4.Utils.Versions`.

Related to #240.
@RyanGlScott RyanGlScott mentioned this issue Oct 12, 2023
Merged
@RyanGlScott
Copy link
Contributor

Thanks, @fosskers! I've submitted #242 to use versions >= 6.0.2 in what4 so that we no longer have to define orphan instances.

RyanGlScott added a commit that referenced this issue Oct 12, 2023
@RyanGlScott
Require versions >= 6.0.2
c3f9e1b 
`versions-6.0.2` introduces a `Lift Version` instance, which finally allows us
to delete the ugly, CPP'd mess of orphan instances that we define in
`What4.Utils.Versions`.

Related to #240.
@RyanGlScott
Copy link
Contributor

I've uploaded what4-1.5.1 to Hackage with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow building with versions-6.0.* GaloisInc/what4
3 participants
@fosskers @swt2c @RyanGlScott