-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No crucible prefix #980
No crucible prefix #980
Conversation
LLVM-specific function names with the prefix "crucible_" have been switched to use the prefix "llvm_".
LLVM-specific function names with the prefix "crucible_" have been switched to use the prefix "llvm_". The original names remain in place, with documentation strings referring to the new names.
See #382. |
…act`. The name "java_extract" was already in use for a deprecated function, and other crucible-based commands mostly use the "jvm_" prefix anyway.
Here's the full list of renamings:
The pattern is quite regular, but for a few exceptions: The I have not updated Also, it would be nice to similarly rename a couple of saw-script type names like |
Would you be able to add some text to I like the |
CrucibleSetup -> LLVMSetup CrucibleMethodSpec -> LLVMSpec JVMMethodSpec -> JVMSpec The old names still work, and are translated to the new ones upon parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks for going as far as updating the help text for the crucible_
commands to mention that they're legacy. We can perhaps deprecate them for the next release.
Add new saw-script function names without "crucible_" prefix.
LLVM-specific function names with the prefix "crucible_" have been switched to use the prefix "llvm_".
The original names remain in place, with documentation strings referring to the new names.