Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodule updates for the fast-f2 cryptol branch #880

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Conversation

robdockins
Copy link
Contributor

No description provided.

@robdockins
Copy link
Contributor Author

@jared-w, @LisannaAtGalois, it seems like these builds are failing on MacOS when building abcBridge with some C error I don't understand about vsnprintf. There hasn't been any updates in abcBridge for months, so it seems like this is a system configuration problem of some sort. Any ideas?

@lisanna-dettwyler
Copy link
Contributor

lisanna-dettwyler commented Oct 28, 2020

@jared-w, @LisannaAtGalois, it seems like these builds are failing on MacOS when building abcBridge with some C error I don't understand about vsnprintf. There hasn't been any updates in abcBridge for months, so it seems like this is a system configuration problem of some sort. Any ideas?

@robdockins And it hasn't always visibly broken the build either: https://github.com/GaloisInc/saw-script/runs/1317864668?check_suite_focus=true#step:9:975

The fix may be as easy as what's suggested here: https://github.com/GaloisInc/saw-script/runs/1322074249?check_suite_focus=true#step:9:983

@robdockins
Copy link
Contributor Author

Interesting. It seems like a warning got upgraded to an error somehow.

The suggested fix is probably the right one in the end, but it needs to happen in abc itself, which is a bit tricky. I think we are lagging quite behind upstream at this point. Given that we're working to move away from abcBridge soon, maybe it would be OK to use some custom patches.

@robdockins robdockins merged commit 9d85f06 into master Oct 28, 2020
@RyanGlScott RyanGlScott deleted the fast-f2 branch March 22, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants