Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86: Truncate RAX when matching smaller return values #847

Merged
merged 6 commits into from
Oct 6, 2020
Merged

x86: Truncate RAX when matching smaller return values #847

merged 6 commits into from
Oct 6, 2020

Conversation

chameco
Copy link
Contributor

@chameco chameco commented Sep 23, 2020

Previously, RAX was simply matchArg -ed against the SetupValue specified with crucible_return, making it impossible to match anything other than a 64-bit return value.

andreistefanescu
andreistefanescu approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/SAWScript/Crucible/LLVM/X86.hs Outdated Show resolved Hide resolved
@chameco chameco merged commit 9a9274c into master Oct 6, 2020
@brianhuffman brianhuffman mentioned this pull request Dec 9, 2020
Closed
@RyanGlScott RyanGlScott added the subsystem: x86 Issues related to verifying x86 binaries via Macaw label Dec 6, 2021
@RyanGlScott RyanGlScott deleted the x86-return-trunc branch March 22, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

Assignees
No one assigned
Labels
subsystem: x86 Issues related to verifying x86 binaries via Macaw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chameco @andreistefanescu @RyanGlScott