Run s2n tests in GitHub Actions #823
Conversation
|
I think everything is working properly at this point - the remaining Actions failure is GHC v8.8.3 on MacOS, which seems to be failing on |
| @@ -6,20 +6,12 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: ${{ matrix.os }} | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
There's a lot of duplication between this one and the macos build.
As far as I can tell, the duplication seems to be in order to avoid uploading artifacts on macos that we won't use? If so, it'd be nice to make the upload artifact step conditional so that it's only ran on linux. Code duplication is very error-prone, particularly inside yaml files, so it's good to be able to avoid it when possible.
There was a problem hiding this comment.
Splitting the build job like this was done to ensure that the s2n-tests job runs even if the build-macos job fails. I agree that this is less than ideal; if there's a better way to accomplish this, let's change it.
There was a problem hiding this comment.
The continue-on-error should've made it so that the s2n-tests job would run even if the macos jobs failed. Was that not the case?
There was a problem hiding this comment.
My impression was that it was allowing the job to complete (i.e. not immediately killing the Ubuntu builds) but still skipping the dependent job. You can see this here: https://github.com/GaloisInc/saw-script/runs/1022813322. It's very possible that I've misinterpreted this, though.
|
Left a few comments, but nothing that would stop this from going in. They can always be addressed later. Let's not make perfect the enemy of good when it come to getting more tests into the CI :) |
This PR updates the GitHub Actions configuration to run the
s2nproof tests.Since reproducing these tests outside of CI has been troublesome in the past, the
s2nTests/directory now contains Docker configurations to make this easier. Runningmake saw-scriptin that directory will build asawexecutable on Ubuntu 18.04 from the current source tree ins2nTests/bin. After this, running (e.g.)make bikewill use that executable to run the BIKE proof.