Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SMT-Lib export negation issues #679

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Fix SMT-Lib export negation issues #679

merged 3 commits into from
Apr 20, 2020

Conversation

atomb
Copy link
Contributor

@atomb atomb commented Apr 17, 2020

This clarifies, and fixes, the polarity of write_smtlib2.

Closes #489, #491.

@atomb atomb linked an issue Apr 17, 2020 that may be closed by this pull request
Unsound? smtlib2 output #491
Closed
andreistefanescu
andreistefanescu approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atomb atomb merged commit 0bc6476 into master Apr 20, 2020
@atomb atomb deleted the at-smtlib-soundness branch April 20, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

@brianhuffman brianhuffman Awaiting requested review from brianhuffman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsound? smtlib2 output Inconsistent smtlib semantics?
2 participants
@atomb @andreistefanescu