Bump crucible and what4 to sync crucible #1260 #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauclovian-g
changed the title
This is a cleanup change that breaks the API (though in a minor way) so we want to keep up with it. Apply the one-line fix to adjust to that change. Update what4 as well because crucible requires it.
sauclovian-g
force-pushed
the
bump-crucible
branch
from
370a731 to
92f29e1
Compare
sauclovian-g
changed the title
sauclovian-g
added
tech debt
RyanGlScott
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crucible #1260 is a cleanup change that breaks the API (though in a minor way) so we want to keep up with it. Apply the one-line fix to adjust to that change.
Update what4 as well because crucible requires it.