Fix interaction between mir_fresh_expanded_value and repr(transparent) structs
#1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qsctr
reviewed
Nov 10, 2023
…ent)` structs Previously, if `mir_fresh_expanded_value` was asked to generate a value whose type was a struct marked `repr(transparent)`, then SAW would produce a value of the underlying type, not the struct type. This fixes the issue by wrapping the underlying value with `SetupStruct`. Fixes #1973.
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
mir_fresh_expanded_valuewas asked to generate a value whose type was a struct markedrepr(transparent), then SAW would produce a value of the underlying type, not the struct type. This fixes the issue by wrapping the underlying value withSetupStruct.Fixes #1973.