Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add composition support to prove_bisim #1972

Merged
merged 8 commits into from
Nov 8, 2023
Merged

Add composition support to prove_bisim #1972

merged 8 commits into from
Nov 8, 2023

Conversation

bboston7
Copy link
Contributor

@bboston7 bboston7 commented Nov 7, 2023

This change enables the reuse of proofs in prove_bisim. prove_bisim now returns a BisimTheorem that can be passed in to future prove_bisim commands to facilitate compositional proofs. To support this, prove_bisim now also requires an additional relation over states. For a detailed description of how this all works, see the module level doc comment in SAWScript.Bisimulation.

This change enables the reuse of proofs in `prove_bisim`.  `prove_bisim`
now returns a `BisimTheorem` that can be passed in to future
`prove_bisim` commands to facilitate compositional proofs.  To support
this, `prove_bisim` now also requires an additional relation over
states.  For a detailed description of how this all works, see the
module level doc comment in `SAWScript.Bisimulation`.
@bboston7 bboston7 added type: enhancement Issues describing an improvement to an existing feature or capability subsystem: hardware Issues related to verification of hardware labels Nov 7, 2023
@bboston7 bboston7 self-assigned this Nov 7, 2023
doc/manual/manual.md Outdated Show resolved Hide resolved
doc/manual/manual.md Show resolved Hide resolved
doc/manual/manual.md Show resolved Hide resolved
doc/manual/manual.md Outdated Show resolved Hide resolved
doc/manual/manual.md Outdated Show resolved Hide resolved
intTests/test_bisimulation/comp.saw Outdated Show resolved Hide resolved
src/SAWScript/Bisimulation.hs Outdated Show resolved Hide resolved
src/SAWScript/Bisimulation/BisimTheorem.hs Outdated Show resolved Hide resolved
src/SAWScript/Bisimulation.hs Outdated Show resolved Hide resolved
src/SAWScript/Bisimulation.hs Outdated Show resolved Hide resolved
@bboston7 bboston7 requested a review from RyanGlScott November 7, 2023 22:43
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the overall look of this PR, with the caveat that I have not looked deeply into the implementation of the new feature. Let me know if there's something that deserves a closer look.

@bboston7 bboston7 merged commit 3b17eb0 into master Nov 8, 2023
37 checks passed
@bboston7 bboston7 deleted the bb/bisim-comp branch November 8, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subsystem: hardware Issues related to verification of hardware type: enhancement Issues describing an improvement to an existing feature or capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants