-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add composition support to prove_bisim
#1972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the reuse of proofs in `prove_bisim`. `prove_bisim` now returns a `BisimTheorem` that can be passed in to future `prove_bisim` commands to facilitate compositional proofs. To support this, `prove_bisim` now also requires an additional relation over states. For a detailed description of how this all works, see the module level doc comment in `SAWScript.Bisimulation`.
bboston7
added
type: enhancement
Issues describing an improvement to an existing feature or capability
subsystem: hardware
Issues related to verification of hardware
labels
Nov 7, 2023
RyanGlScott
reviewed
Nov 7, 2023
Co-authored-by: Ryan Scott <[email protected]>
RyanGlScott
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overall look of this PR, with the caveat that I have not looked deeply into the implementation of the new feature. Let me know if there's something that deserves a closer look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
subsystem: hardware
Issues related to verification of hardware
type: enhancement
Issues describing an improvement to an existing feature or capability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables the reuse of proofs in
prove_bisim
.prove_bisim
now returns aBisimTheorem
that can be passed in to futureprove_bisim
commands to facilitate compositional proofs. To support this,prove_bisim
now also requires an additional relation over states. For a detailed description of how this all works, see the module level doc comment inSAWScript.Bisimulation
.