Add simple bisimulation prover #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds command `prove_bisim` that proves that two terms simulate eachother. Given a relation `rel`, term `lhs`, and term `rhs`, the prover considers `lhs` and `rhs` bisimilar when: ``` forall s1 s2 in out. rel (s1, out) (s2, out) -> rel (lhs (s1, in)) (rhs (s2, in)) ```
RyanGlScott
reviewed
Sep 6, 2023
There was a problem hiding this comment.
This does what it advertises, so I'm happy with this. I've left a number of suggestions inline, but some of these suggestions may not be applicable, as I'm not completely sure how the bisimulation prover is intended to be used in future work.
As a high-level suggestion: my understanding is that it took a fair bit of discussion and thought to arrive at the current design for the bisimulation prover. I think it would be helpful to capture some of that discussion in a Note somewhere in the comments, including some examples of other design possibilities that were rejected (and with reasons why they were rejected).
Co-authored-by: Ryan Scott <[email protected]>
RyanGlScott
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds command
prove_bisimthat proves that two terms simulate eachother. Given a relationrel, termlhs, and termrhs, the prover considerslhsandrhsbisimilar when: