Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump submodule versions #1913

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

RyanGlScott
Copy link
Contributor

This is primarily motivated by a need to bring in a fix for GaloisInc/crucible#1105 into SAW soon. In order to do this, I will need to bump the crucible submodule to a more recent commit, so this patch lays the groundwork for doing so.

This is primarily motivated by a need to bring in a fix for
GaloisInc/crucible#1105 into SAW soon. In order to do
this, I will need to bump the `crucible` submodule to a more recent commit, so
this patch lays the groundwork for doing so.

Most of the changes can be brought in directly without any further changes to
SAW.  One exception in `cryptol`, where I had to explicitly initialize
`mInScope` to accommodate the changes from
GaloisInc/cryptol#1559.  Just like how `cryptol`
initializes `mInScope` to `mempty` after parsing a Cryptol `NormalModule`, so
too does SAW.
@RyanGlScott RyanGlScott force-pushed the bump-submodules-preparing-for-crucible-1105 branch from 864365f to 0f200d9 Compare August 21, 2023 17:38
@RyanGlScott RyanGlScott force-pushed the bump-submodules-preparing-for-crucible-1105 branch from 0f200d9 to 76b2044 Compare August 21, 2023 19:15
@RyanGlScott RyanGlScott marked this pull request as ready for review August 21, 2023 22:10
@RyanGlScott RyanGlScott requested a review from kquick August 21, 2023 22:10
@RyanGlScott RyanGlScott added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Aug 21, 2023
@mergify mergify bot merged commit 64f41ca into master Aug 21, 2023
@mergify mergify bot deleted the bump-submodules-preparing-for-crucible-1105 branch August 21, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants