Allow use of Cryptol property names as simplification rules #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite rules" This reverts commit a4a743c.
Better than the earlier approach, this leverages the fact that every unfoldable constant is constructed with a `Just body` and restricts unfolding to happen within `ruleAsProp`. Also, pipe a `SharedContext` to `ruleAsProp` to allow leveraging `scApplyAllBeta` to beta-reduce the unfolded term before checking rule well-formedness again.
Also, previous commits' references to `ruleAsProp` should have been to `ruleOfProp`.
|
For some reason, I'm only just now seeing these CI failures when running tests on my machine. Review may not yet be appropriate, so I'm going to demote this to draft status while I poke around. |
eddywestbrook
approved these changes
Oct 18, 2022
samcowger
added
the
PR: ready to merge
weaversa
added a commit
to weaversa/aes-rust
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to
proveCryptol properties by name, without unfolding, and use them as simplification rules in SAW. (The former was already possible, this PR introduces the latter as a new capability.) See the included regression test for an example.