Minor Heapster docfixes #1752
Merged
Minor Heapster docfixes #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`nm_t` is a typo and is actually meant to refer to `nm_to`. [ci skip]
The documentation for `fieldsh(p)` claims that it acts on a pointer of unknown size. This isn't really true, however, as it is really a shorthand for `fieldsh(w,p)`, where `w` is the current pointer size. I found the original documentation misleading enough to the point where I think it deserves to be rewritten, which I have accomplished in this patch. [ci skip]
RyanGlScott
added
the
subsystem: heapster
RyanGlScott
commented
Oct 11, 2022
eddywestbrook
approved these changes
Dec 14, 2022
RyanGlScott
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two minor documentation fixes involving Heapster:
heapster_assume_fun_rename,nm_tis a typo and is actually meant to refer tonm_to.fieldsh(p)claims that it acts on a pointer of unknown size. This isn't really true, however, as it is really a shorthand forfieldsh(w,p), wherewis the current pointer size.