Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrayEq primitive #1713

Merged
merged 3 commits into from
Jul 27, 2022
Merged

arrayEq primitive #1713

merged 3 commits into from
Jul 27, 2022

Conversation

robdockins
Copy link
Contributor

Pipe through the arrayEq primitive so it can be mentioned in Cryptol specifications

@robdockins robdockins marked this pull request as ready for review July 25, 2022 23:54
@robdockins
Bump cryptol submodule
cf45256
@robdockins
Load and bring into scope the magic Cryptol Array module.
7178e01 
Perhaps this should be configurable; or we should implement
the ability to load modules by name to avoid needing this
to be baked-in.
@robdockins
Add Cryptol->SAWCore bindings for arrayEq
de583b0
@robdockins robdockins requested a review from chameco July 26, 2022 21:00
@robdockins robdockins added the PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run label Jul 26, 2022
chameco
chameco approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@chameco chameco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robdockins robdockins merged commit f71a795 into master Jul 27, 2022
@mergify mergify bot deleted the rwd/arrayEq branch July 27, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

@chameco chameco chameco approved these changes

Assignees
No one assigned
Labels
PR: ready to merge Magic flag for pull requests to ask Mergify to merge given an approval and a successful CI run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robdockins @chameco @andreistefanescu