Expand Mr. Solver heterogeneity, improve monadification for SHA512 example #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c in order to get monadification to work
m-yac
added
the
subsystem: MRSolver
eddywestbrook
approved these changes
Jun 10, 2022
eddywestbrook
added
the
PR: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two main parts:
openOpenTermand fixes some other bugs involving free variables in MonadificationThe former enabled the refinement
processBlock |= processBlock_specto go through, and the latter enabledprocessBlocks_specto monadify. Of course, both of these also needed other, smaller, changes - each commit should be self-contained enough to review individually.My final batch of commits at the end are to make progress on
processBlocks |= processBlocks_spec(note the "s"es), but this refinement does not yet go through, so it is commented out.